Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added emits and onSubmit custom prop #3115

Merged
merged 1 commit into from Jan 11, 2021
Merged

fix: added emits and onSubmit custom prop #3115

merged 1 commit into from Jan 11, 2021

Conversation

logaretm
Copy link
Owner

馃攷 Overview

The Form component emitting submit event with different signature than the default event handlers.

This PR adds onSubmit prop and emits prop so tools like volar and vue-dx can pick up the types correctly.

vuejs/language-tools#41

closes #3114

@logaretm logaretm merged commit 8f2c110 into main Jan 11, 2021
@logaretm logaretm deleted the fix/3112 branch January 11, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onSubmit event type not working with volar
1 participant
@logaretm