Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorMessage component render empty tag even if no error #3118

Closed
yaquawa opened this issue Jan 12, 2021 · 4 comments
Closed

ErrorMessage component render empty tag even if no error #3118

yaquawa opened this issue Jan 12, 2021 · 4 comments
Labels
✨ enhancement a "nice to have" feature

Comments

@yaquawa
Copy link

yaquawa commented Jan 12, 2021

Versions

  • vee-validate: 4.1.7
  • vue: 3.0.1

Describe the bug
ErrorMessage component render empty tag even if no error occured.

@logaretm
Copy link
Owner

logaretm commented Jan 12, 2021

This is intended at the moment, but I'm inclined to agree that it shouldn't render anything if no errors exist, will think about it.

@logaretm logaretm added the ✨ enhancement a "nice to have" feature label Jan 12, 2021
@yaquawa
Copy link
Author

yaquawa commented Jan 13, 2021

This is intended at the moment

I have some styles on the error message element. For example margin-top: 1em.
If it render the error element even if there is no error, the 1em margin still shown, which looks strange.

If you may keep as it is, could you tell me how to hide the error element with the current version ? Thanks!

@logaretm
Copy link
Owner

I tagged 4.1.8 with this change. For older releases you can do use absolute + padding-bottom.

@yaquawa
Copy link
Author

yaquawa commented Jan 13, 2021

cool! confirmed the change, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement a "nice to have" feature
Projects
None yet
Development

No branches or pull requests

2 participants