Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added language specific default #3501

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

martijn788
Copy link
Contributor

馃攷 Overview

Added a feature to add a language specific default.
Current behaviour was always an English message.

Logic:
if for the specific language a _default is set, then show that default.
If there is no default set, the fallback-english is used.

@codecov-commenter
Copy link

Codecov Report

Merging #3501 (b8aac6c) into main (87df597) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3501      +/-   ##
==========================================
- Coverage   96.71%   96.65%   -0.06%     
==========================================
  Files          65       65              
  Lines        1613     1616       +3     
  Branches      394      398       +4     
==========================================
+ Hits         1560     1562       +2     
- Misses         52       53       +1     
  Partials        1        1              
Impacted Files Coverage 螖
packages/i18n/src/index.ts 75.00% <66.66%> (-0.56%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 87df597...b8aac6c. Read the comment docs.

Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice addition, thank you!

@logaretm logaretm merged commit debdee0 into logaretm:main Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants