Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validationAll(scope) always return true in 2.0.0.rc-8 #699

Closed
Yeenot opened this issue Aug 2, 2017 · 3 comments
Closed

validationAll(scope) always return true in 2.0.0.rc-8 #699

Yeenot opened this issue Aug 2, 2017 · 3 comments
Labels
🐛 bug Unintended behavior

Comments

@Yeenot
Copy link

Yeenot commented Aug 2, 2017

Versions:

  • VueJs: 2.4.1
  • Vee-Validate: 2.0.0.rc-8

Description:

I've encountered some problems using validationAll(scope). It always return true but if I remove the scope it will run correctly and will detect errors

In my form I do have this tho
data-vv-scope="form-1"

And in my components, i've been using vuetifyjs.

Steps To Reproduce:

@logaretm
Copy link
Owner

logaretm commented Aug 3, 2017

Do you mind setting up a jsfiddle? It is either the fields aren't being scoped properly or the pipeline has issues.

@logaretm logaretm added 🤔 needs reproduction This issue requires a demo and removed 🤔 needs reproduction This issue requires a demo labels Aug 3, 2017
@logaretm
Copy link
Owner

logaretm commented Aug 3, 2017

never mind, I've set it up using an example laying around and there seems to be an issue with it indeed, I've addressed the issue in a recent commit, it had to do with scope resolution for custom components.

Note that data-vv-scope does not work for components within forms. It only works for native HTML inputs. You would need to add data-vv-scope to each component to register it properly.

https://jsfiddle.net/logaretm/f7fxvL82/1/

Should be up with the next release.

@logaretm logaretm added the 🐛 bug Unintended behavior label Aug 3, 2017
@Yeenot
Copy link
Author

Yeenot commented Aug 3, 2017

Thank you! Will be looking forward to it on the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants