Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach method ($validator.detach) doesn't update "fields"-property #751

Closed
dandob74 opened this issue Aug 23, 2017 · 2 comments
Closed

Detach method ($validator.detach) doesn't update "fields"-property #751

dandob74 opened this issue Aug 23, 2017 · 2 comments
Labels
🐛 bug Unintended behavior

Comments

@dandob74
Copy link

Versions:

  • VueJs: 2.4.2
  • Vee-Validate: v2.0.0-rc.13

Description:

The $validator.detach method doesn't update/trigger the fields/fieldBag property.

Steps To Reproduce:

https://jsfiddle.net/p28e8a95/40/
Removing an input element within this fiddle should update the fields prop accordingly.

@logaretm logaretm added the 🐛 bug Unintended behavior label Aug 23, 2017
@logaretm
Copy link
Owner

Thanks for reporting this, I pushed a small fix for it and it should be up with the next tag, I have a small observation tho, you don't have to detach the field if you are splicing it from the array, detach will be called automatically once the field is spliced from the array.

@dandob74
Copy link
Author

Perfect!!!! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants