Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

[Fixed #17] Offline issues #18

Merged
merged 2 commits into from Mar 31, 2015
Merged

Conversation

hirro
Copy link
Contributor

@hirro hirro commented Mar 31, 2015

IOException must be thrown for the outer logic to work correctly.

Otherwise, the stream will be null which leads to NPE that exits the publishing loop.

Online -> Offline -> Online works fine now

IOException must be thrown for the outer logic to work correct.
@@ -219,11 +229,11 @@ public void run(){
// Send data, reconnect if needed
while (true){
try{
stream.write( msg);
stream.flush();
stream.write( msg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing the indentation?

@StephenHynes7
Copy link
Contributor

Looks good, not sure why the indentation was moved though.

@hirro
Copy link
Contributor Author

hirro commented Mar 31, 2015

Hi Stephen!

Sorry about that, I noticed that you use tabs instead of spaces when I
posted the PR.

I'll update the commit.

Best Regards,
Jim

2015-03-31 11:54 GMT+02:00 Stephen Hynes notifications@github.com:

Looks good, not sure why the indentation was moved though.


Reply to this email directly or view it on GitHub
#18 (comment).

@hirro
Copy link
Contributor Author

hirro commented Mar 31, 2015

Hi again,

There is a new commit with the indentation fixes.

/Jim

2015-03-31 13:07 GMT+02:00 Jim Arnell jim@arnellconsulting.com:

Hi Stephen!

Sorry about that, I noticed that you use tabs instead of spaces when I
posted the PR.

I'll update the commit.

Best Regards,
Jim

2015-03-31 11:54 GMT+02:00 Stephen Hynes notifications@github.com:

Looks good, not sure why the indentation was moved though.


Reply to this email directly or view it on GitHub
#18 (comment).

@StephenHynes7
Copy link
Contributor

Great thanks! Ill merge this in and update the jar

StephenHynes7 pushed a commit that referenced this pull request Mar 31, 2015
[Fixed #17] Offline issues
@StephenHynes7 StephenHynes7 merged commit bfe2f30 into LogentriesCommunity:master Mar 31, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants