Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and remove usage of nested appenders in examples #871

Closed
brenuart opened this issue Oct 7, 2022 · 0 comments · Fixed by #875
Closed

Update README and remove usage of nested appenders in examples #871

brenuart opened this issue Oct 7, 2022 · 0 comments · Fixed by #875

Comments

@brenuart
Copy link
Collaborator

brenuart commented Oct 7, 2022

Declaring an <appender> inside another <appender> is not allowed anymore since Logback 1.3+ (see https://jira.qos.ch/browse/LOGBACK-1674 for more information).

We should update the documentation and remove sample configurations like the following:

<appender name="async" class="net.logstash.logback.appender.LoggingEventAsyncDisruptorAppender">
    <appender class="ch.qos.logback.core.rolling.RollingFileAppender">
        ...
    </appender>
</appender>

and replace them with:

<appender name="file" class="ch.qos.logback.core.rolling.RollingFileAppender">
    ...
</appender>

<appender name="async" class="net.logstash.logback.appender.LoggingEventAsyncDisruptorAppender">
    <appender-ref ref="file" />
</appender>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant