Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOPSWORKS-1124] optimize scp-deploy-frontend.sh #260

Merged
merged 1 commit into from Jul 5, 2019

Conversation

kai-chi
Copy link
Contributor

@kai-chi kai-chi commented Jun 10, 2019

Make sure there is no duplicate PR for this issue

  • Please check if the PR meets the following requirements
  • Adds tests for the submitted changes (for bug fixes & features)
  • Passes the tests
  • HOPSWORKS JIRA issue has been opened for this PR
  • All commits have been squashed down to a single commit
  • Post a link to the associated JIRA issue
    https://logicalclocks.atlassian.net/browse/HOPSWORKS-1124

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Improvement to the script.

  • What is the new behavior (if this is a feature change)?
    Reduced the time from ~90 seconds to ~20 seconds.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@tkakantousis
Copy link
Contributor

tkakantousis commented Jun 11, 2019

@kai-chi Touch fails with

touch: missing file operand
Try 'touch --help' for more information.

@tkakantousis
Copy link
Contributor

Also the master branch version takes ~10 seconds for me even when I'm not on the same network as Hopsworks.

@kai-chi
Copy link
Contributor Author

kai-chi commented Jun 11, 2019

fixed the issue with touch.

I tried from different networks from Spain with very high upload bandwidth and it never went below 70 seconds

@tkakantousis tkakantousis merged commit 0f0feb1 into logicalclocks:master Jul 5, 2019
@kai-chi kai-chi deleted the i-1124 branch August 8, 2019 14:52
kouzant pushed a commit to kouzant/hopsworks that referenced this pull request Apr 25, 2020
SirOibaf pushed a commit to SirOibaf/hopsworks that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants