Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check of number_of_features_or_feed of ltn.variable #7

Closed
ivanDonadello opened this issue Nov 20, 2018 · 2 comments
Closed

Check of number_of_features_or_feed of ltn.variable #7

ivanDonadello opened this issue Nov 20, 2018 · 2 comments

Comments

@ivanDonadello
Copy link

Hello,

when we define a variable with ltnw.variable('name', num_feats) if num_feats is a numpy.int_ ltn instantiates a variable with a wrong shape. I guess this is due to the control at line 185 here https://github.com/logictensornetworks/logictensornetworks/blob/master/logictensornetworks.py, as a numpy.int_ is not an int. A check like this if type(number_of_features_or_feed) is int or type(number_of_features_or_feed) is numpy.int_ should work.

@mspranger
Copy link
Member

Thanks Ivan! Let me check and update this within the next few days

@sbadredd
Copy link
Member

sbadredd commented Nov 5, 2021

Closing because we are not maintaining the older version of LTN anymore
The solution pointed out by Ivan should work though 👍

@sbadredd sbadredd closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants