Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNC plugin error on reading and parsing registry key #10

Closed
Th3l5D opened this issue Oct 6, 2021 · 2 comments
Closed

VNC plugin error on reading and parsing registry key #10

Th3l5D opened this issue Oct 6, 2021 · 2 comments

Comments

@Th3l5D
Copy link

Th3l5D commented Oct 6, 2021

The VNC plugin in software/sysadmin/vnc.py does not handle properly the read of a registry key.

There is two issues:

  • After getting the key from registry, the variable is bytes, but on line 107, you triy to rstrip() some string, causing an error.
  • On the reverse_vncpassword method, you try to unhex/hex the same variable, but as it's bytes and not a string hex representation, it fails.
@Th3l5D
Copy link
Author

Th3l5D commented Oct 6, 2021

Will send a PR with a fix (tested only on thightVNC on a single asset) in a second if I understand how it works :D

Edit : PR sent. Please note that I fixed the issue and removed the (now useless) unhex method. I did NOT rewrote any part of the code to be more readable.

@login-securite
Copy link
Owner

Thanks ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants