Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the link to Snap #1614

Merged
merged 1 commit into from Jan 11, 2023
Merged

Conversation

R3dst0ne
Copy link
Contributor

Since having an outdated official Snap package (Neither stable nor nightly are up-to-date) is in no way beneficial.
I propose removing the links to it until this gets fixed.

As soon as it gets updated to the current version (3.8.0), I will add the links again.

If this PR gets accepted, I will create another one for the develop branch.

Since having an outdated official Snap package (Neither `stable` nor `nightly` are up-to-date) is in no way beneficial.
I propose removing the links to it until this gets fixed.

As soon as it gets updated to the current version (3.8.0), I will add the links again.

If this PR gets accepted, I will create another one for the `develop` branch.
Copy link
Member

@MarcinOrlowski MarcinOrlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the banner from master only as we want them fixed not removed anyway. But instead of spending time on removing the banner you might want to take a look at builder scripts to see maybe you will see what the issue is there?

Copy link
Member

@maehne maehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @R3dst0ne to remove link from master, but not from develop. However, we need to be sure, once the Snap package is fixed that the README contains the link again after merging develop into master.

@R3dst0ne
Copy link
Contributor Author

Sadly, I do not have any experience with Snap's or configuring build processes. So fixing this has to be done by someone else.
@MarcinOrlowski maybe you as the creator of the Snap and @anrouxel as the creator of the unofficial one can work together to fix this.

After short reconsideration, I agree that the banner and link should stay in the README on develop.

@BFH-ktt1 what is your opinion on this topic?
Is something stopping you from merging this PR?

@BFH-ktt1 BFH-ktt1 merged commit 0f2bb01 into logisim-evolution:master Jan 11, 2023
@R3dst0ne R3dst0ne deleted the patch-2 branch January 25, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants