Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly build is not triggered Nightly #1714

Closed
R3dst0ne opened this issue Apr 6, 2023 · 2 comments · Fixed by #1796
Closed

Nightly build is not triggered Nightly #1714

R3dst0ne opened this issue Apr 6, 2023 · 2 comments · Fixed by #1796

Comments

@R3dst0ne
Copy link
Contributor

R3dst0ne commented Apr 6, 2023

While looking at the nightly builds, I noticed that there is a build for each commit.
Is this wanted behavior?
What is the status on this one?

name: "Nightly"
on:
# The "pull_request" trigger is here for debugging purposes and
# as work-around for having this worker not yet in main branch.
# Keep it disabled once it's merged into main branch as we only
# want "schedule" to be the trigger.
# NOTE: remove `if` condition marked with `HACK` once merged.
# pull_request:
# # Nightly must be run against "develop" branch only.
# branches: [ develop ]
# types: [ closed ]
# schedule:
# # every day at midnight
# - cron: "0 0 * * *"

@davidhutchens
Copy link
Member

The problem, as I understand it, is that scheduled workflows only work on the default branch. We cannot easily schedule a nightly build that runs each night on the develop branch. Therefore, this issue is related to #1552. See my suggestion there.

@davidhutchens
Copy link
Member

Since we now have main as the default branch Nightly is running at midnight. PR #1796 adjusts it to only run at midnight and not run after each closed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants