Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the "sharedscripts" option really imply the "create" option? #336

Closed
mkauf opened this issue Jun 29, 2020 · 2 comments · Fixed by #340
Closed

Does the "sharedscripts" option really imply the "create" option? #336

mkauf opened this issue Jun 29, 2020 · 2 comments · Fixed by #340

Comments

@mkauf
Copy link

mkauf commented Jun 29, 2020

From the man page:

sharedscripts: ... This option overrides the nosharedscripts option and implies create option.

I think that this makes no sense, so I have tested this and had a quick glance at the source code. If I tested correctly, then "sharedscripts" does not imply the "create" option.

Also, I found this logrotate configuration for chrony on Fedora, which uses both "sharedscripts" and "nocreate":

/var/log/chrony/*.log {
    missingok
    nocreate
    sharedscripts
    postrotate
        /usr/bin/chronyc cyclelogs > /dev/null 2>&1 || true
    endscript
}

Please verify this, and fix the man page if necessary.

@kdudka
Copy link
Member

kdudka commented Jul 2, 2020

The statement appeared in the man page 15 years ago in commit 62b4a6f without any explanation. I fail to see any reason why sharedscripts would imply create. So I propose to just remove the statement from the man page.

@mkauf
Copy link
Author

mkauf commented Jul 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants