Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on F-Droid #10449

Closed
LoeschMaximilian opened this issue Nov 1, 2023 · 14 comments
Closed

Release on F-Droid #10449

LoeschMaximilian opened this issue Nov 1, 2023 · 14 comments
Assignees
Labels
build Build & Development mobile:android :type/enhancement Enhancement to product. Does not affect the overall basic use. upstream Blocked by upstream deps

Comments

@LoeschMaximilian
Copy link

It would be nice to relase the android builds on f-droid

@alxlg
Copy link
Collaborator

alxlg commented Nov 2, 2023

For it to happen, Logseq team needs to release the source code of the part that handles Sync client-side. I have no idea why they are keeping it closed source.

@andelf andelf self-assigned this Nov 2, 2023
@andelf andelf added the :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. label Nov 2, 2023
@andelf
Copy link
Collaborator

andelf commented Nov 2, 2023

Thanks for your reminder.

It takes time to filter out old commits, which might contain secret keys or credentials for historical reasons.

So I just strip out old commits. Sorry for the inconvenience. Check it at https://github.com/logseq/rsapi

Regarding the Logseq Sync implementation, the underlying code is not confidential. You can find the Swift implementation of the iOS version on GitHub, which is open-source.

I have assigned myself to address this issue promptly. Additionally, I will work on getting Logseq listed on F-droid. You can track the progress of this task at Gitlab tracking issue: !13971

@andelf andelf mentioned this issue Nov 2, 2023
2 tasks
@andelf andelf added :type/enhancement Enhancement to product. Does not affect the overall basic use. build Build & Development upstream Blocked by upstream deps and removed :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. labels Nov 2, 2023
@andelf
Copy link
Collaborator

andelf commented Nov 2, 2023

Marked as upstream since F-Droid seems to reject hand-written installation of Clojure in its building process:

  • I'm not a Debian user. Debian's default clojure dpkg uses the ancient java -jar clojure.jar for clojure command instead of clojure-tools
  • F-Droid rejects "download a script and run", which means Clojure installation script is not acceptable
  • Hand-written install process is not acceptable because nodejs is F-droid's only exception

@andelf andelf assigned andelf and unassigned andelf Nov 2, 2023
@linsui
Copy link
Contributor

linsui commented Nov 12, 2023

@andelf I solved the clojure issue and now we need to build rsapi. :)

@linsui
Copy link
Contributor

linsui commented Dec 17, 2023

I also build the rsapi from source. But you need to add the fastlane in this repo. See https://gitlab.com/snippets/1895688. @andelf

@aadityabhatia
Copy link

Looking at fastlane documentation. It appears that the tool is fairly simple to setup. The only complex part is getting it to auto-generate slick screenshots that convince users to install the app.

Is that the only thing holding up F-Droid offering? If so, I can work on getting fastlane working and submit a PR.

@linsui
Copy link
Contributor

linsui commented Jan 18, 2024

See https://gitlab.com/snippets/1895688. F-Droid only needs the metadata.

@linsui
Copy link
Contributor

linsui commented Jan 26, 2024

Looks like I have to do that myself... #10925

@linsui
Copy link
Contributor

linsui commented Feb 16, 2024

It's published.

@LoeschMaximilian
Copy link
Author

i just tried it, and play protect blocked the app, because the developer was not recognized

Screenshot_20240216_103835.jpg

sorry for the german screenshot.

This leads to failure of the installation process.

@linsui
Copy link
Contributor

linsui commented Feb 16, 2024

Please report the issue to Google. It's their problem.

@jtrees
Copy link

jtrees commented Feb 18, 2024

Hooray! Thanks everyone.

@alxlg alxlg closed this as completed Feb 18, 2024
@KAGEYAM4
Copy link

is there seprate issue for tracking changes regarding fdroid showing up on https://logseq.com/downloads, i though google-play was the only way and gonna instead go for apk from github.

@alxlg
Copy link
Collaborator

alxlg commented Mar 26, 2024

is there seprate issue for tracking changes regarding fdroid showing up on https://logseq.com/downloads, i though google-play was the only way and gonna instead go for apk from github.

The issues about the website are here:

https://github.com/logseq/sites/issues

Maybe open one there, since there isn't one about F-droid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build & Development mobile:android :type/enhancement Enhancement to product. Does not affect the overall basic use. upstream Blocked by upstream deps
Projects
None yet
Development

No branches or pull requests

7 participants