Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property names in graph #6124

Closed
theBenForce opened this issue Jul 20, 2022 · 9 comments · Fixed by #6138
Closed

Property names in graph #6124

theBenForce opened this issue Jul 20, 2022 · 9 comments · Fixed by #6138
Labels
props Properties :type/bug Something isn't working. Affects daily use.

Comments

@theBenForce
Copy link

What happened?

I just upgraded to version 0.7.7 on MacOS and now I see all of my page property names in the graph.

Reproduce the Bug

  1. Add the same property to a few different pages
  2. Go to 'Graph view'
  3. You'll see the name of that property in the graph

Expected Behavior

I shouldn't see page property names in the graph

Screenshots

No response

Desktop Platform Information

MacOS 12.4, Logseq 0.7.7

Mobile Platform Information

No response

Additional Context

There are a few properties that I add to most pages, like type. Since they connect to most pages their node is massive and all of the connections coming out of them make the graph pretty well unusable.

@cnrpman cnrpman added the props Properties label Jul 20, 2022
@cnrpman
Copy link
Collaborator

cnrpman commented Jul 20, 2022

There's a config option provided

logseq/templates/config.edn

Lines 215 to 220 in a0087d7

;; Enable all your properties to have corresponding pages
:property-pages/enabled? true
;; Properties to exclude from having property pages
;; E.g. #{:duration :author}
;; :property-pages/excludelist

@cnrpman cnrpman added the :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. label Jul 20, 2022
@theBenForce
Copy link
Author

Just added this to my config and I'm still seeing property pages after multiple application restarts, refreshes, and re-indexings.

 :property-pages/enabled? false

@Edmund-D
Copy link

I encountered the same problem

@Edmund-D
Copy link

Reproduction: Create new "Properties" → Delete "Properties" page from all pages → Re-create index → Go to "Atlas view"
Environment: win10-x64
Version: 0.7.6+nightly.20220718

@cnrpman
Copy link
Collaborator

cnrpman commented Jul 21, 2022

Just added this to my config and I'm still seeing property pages after multiple application restarts, refreshes, and re-indexings.

 :property-pages/enabled? false

May @cldwalker have a look on this?

@WsinGithub
Copy link
Contributor

image
With :property-pages/enabled? false, the properties-key can't be clicked anymore. However, the linked references still envolved property-pages.

@cnrpman
Copy link
Collaborator

cnrpman commented Jul 21, 2022

Just added this to my config and I'm still seeing property pages after multiple application restarts, refreshes, and re-indexings.

 :property-pages/enabled? false

Sounds these property key pages are still linked in the linked reference section.
Ideally these pages could be removed via remove orphan pages when the config option is set to false.

@logseq-cldwalker
Copy link
Collaborator

logseq-cldwalker commented Jul 21, 2022

@theBenForce Looks like there's a caching issue. You can workaround most of this bug by backing up your data, deleting logseq/pages-metadata.edn and then re-indexing. Your block property pages should then be deleted but page property pages won't be deleted yet. There's a bug with page property pages not respecting the config option so I'll have a fix for that soon
@cnrpman Looks like there's a separate bug where we don't delete pages on re-index if they exist in logseq/pages-metadata.edn Nevermind. Looks like deletion works consistently after two re-indexes

@theBenForce
Copy link
Author

Thanks for working on it @logseq-cldwalker!

@logseq-cldwalker logseq-cldwalker added :type/bug Something isn't working. Affects daily use. and removed :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
props Properties :type/bug Something isn't working. Affects daily use.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants