Open New Window doesn't work in Linux

[abijr]

What happened?

Trying to open an additional window in Linux doesn't work.

Reproduce the Bug

1. Use the right click menu for Logseq (in Gnome3)
2. Click on New Window
3. Error shows up:

[Main Exception]
Invalid URL
TypeError [ERR_INVALID_URL]: Invalid URL
at new NodeError (node:internal/errors:371:5)
at onParseError (node:internal/url:552:9)
at new URL (node:internal/url:628:5)
at Deeplink.<anonymous> (/tmp/.mount_Logseqv0XEFD/resources/app/electron.js:14933:326)
at Deeplink.emit (node:events:526:28)
at Deeplink._this.secondInstanceEvent (/tmp/.mount_Logseqv0XEFD/resources/app/node_modules/electron-deeplink/dist/index.js:78:23)
at App.emit (node:events:538:35)

Expected Behavior

I expect a new window to show up.

Screenshots

Desktop Platform Information

Fedora 36, AppImage 0.82

Mobile Platform Information

No response

Additional Context

Tried different ways to get the new window to open up, such as setting a shortcut for ui/open-new-window in the config.edn

This feature works as expected on OSX.

[Verneri]

just noticed the same problem on Arch Linux and AppImage

Following Exception comes out when starting from terminal

0:13:47.996 › Logseq App(0.8.2) Starting... 
10:14:04.544 › open-url {:url "--allow-file-access-from-files"}
uncaughtException TypeError [ERR_INVALID_URL]: Invalid URL
    at new NodeError (node:internal/errors:371:5)
    at onParseError (node:internal/url:552:9)
    at new URL (node:internal/url:628:5)
    at Deeplink.<anonymous> (/tmp/.mount_logseqsSvNGY/resources/app/electron.js:14933:326)
    at Deeplink.emit (node:events:526:28)
    at Deeplink._this.secondInstanceEvent (/tmp/.mount_logseqsSvNGY/resources/app/node_modules/electron-deeplink/dist/index.js:78:23)
    at App.emit (node:events:538:35) {
  input: '--allow-file-access-from-files',
  code: 'ERR_INVALID_URL'
}

[cnrpman]

@Verneri Thank you for the console output you cached! Seems a Logseq protocol is mistakenly triggered on opening new window on Linux.

Some investigation in depth is required to find out the new window mechanism on these OS, but a fast fix would be filtering the --allow-file-access-from-files string in the URL handler

logseq/src/electron/electron/core.cljs

Lines 45 to 54 in b15da3e

	(defn open-url-handler
	"win - the main window instance (first renderer process)
	url - the input URL"
	[win url]
	(.info logger "open-url" (str {:url url}))
	(let [parsed-url (js/URL. url)
	url-protocol (.-protocol parsed-url)]
	(when (= (str LSP_SCHEME ":") url-protocol)
	(logseq-url-handler win parsed-url))))

[pwright]

Any workaround? or should i revert to 0.8.2? or might that cause me more issues?

[pwright]

To answer my own question (about workaround): If you construct a logseq url (logseq://graph/<graph>), you can open multiple windows on linux avoiding this issue.

[abijr]

Fixed in version 0.8.4, shift+ctrl+n is working again Linux.

I think this was the fix: 496c2b4

Thanks team!