Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old file not deleted when renaming page between capitalization changes and cause conflict #6595

Open
outinspace opened this issue Sep 4, 2022 · 9 comments
Labels
filenames fs File system mobile:ios need-to-reproduce More clues are required to reproduce the issue. page-rename

Comments

@outinspace
Copy link

outinspace commented Sep 4, 2022

What happened?

I created a page, added some content, and then renamed the page. I was prompted to confirm that I wanted to rename the page. I then added more content to the page and exited the app. I am on IOS using a local directory as my graph. I use Working Copy (git client) to commit and push changes to my notes. After renaming a page, I do not see the changes appear in the Files app (file explorer) or Working Copy.

Reproduce the Bug

  1. Create a page on a local graph on IOS
  2. Add content to the page
  3. Exit the app
  4. Open the app
  5. Rename the page and add new content
  6. Close the app
  7. Open Files and try finding the page file

Expected Behavior

I expect to find the page file renamed with updated content.

Screenshots

No response

Desktop Platform Information

No response

Mobile Platform Information

IOS 15.6.1
iPhone 13

Logseq 0.8.2

Additional Context

I have my graph configured to use org-mode for new pages.

@cnrpman
Copy link
Collaborator

cnrpman commented Sep 5, 2022

Are you renaming page to names with spaces / special characters?
Since you are using 0.8.2, can you upgrade to the latest version? It contains some fixes toward file path on mobile clients.
Ref: #6474

@cnrpman cnrpman added the :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. label Sep 5, 2022
@outinspace
Copy link
Author

outinspace commented Sep 5, 2022 via email

@cnrpman
Copy link
Collaborator

cnrpman commented Sep 5, 2022

@outinspace I see.
Confirm, the fix towards this issue is still under Test Flight. Will make it available in app store soon.

@cnrpman cnrpman added fixed-next-release ✅ Fixed, will be in the next release mobile:ios and removed :type/question Not bug, closed at will. Frequently asked ones would be collected in Logseq Forum's FAQ section. labels Sep 5, 2022
@outinspace
Copy link
Author

@cnrpman do you know when this is planned to be released?

@logseq-cldwalker
Copy link
Collaborator

@outinspace Can you try this again with 0.8.10?

@logseq-cldwalker logseq-cldwalker added the awaiting-response Issue will be closed if a reply is not received label Nov 1, 2022
@outinspace
Copy link
Author

@logseq-cldwalker It mostly works now. I can rename a page to have spaces and hyphens in the title. However, when leaving the app to go to Working Copy (my git client) and returning back to Logseq, I get the following error every time:

IMG_6940

@cnrpman
Copy link
Collaborator

cnrpman commented Nov 3, 2022

@outinspace Sounds to be related to capitalization of the file names. Can you check the file names of this page on all of your devices?

@cnrpman cnrpman added filenames and removed fixed-next-release ✅ Fixed, will be in the next release awaiting-response Issue will be closed if a reply is not received labels Nov 3, 2022
@situ2001
Copy link
Collaborator

situ2001 commented Jun 6, 2023

I have encountered this issues once when I renamed just the capitalization of a page, for example, from vue to Vue, and the old file was not deleted.

IMG_6579C2C615E5-1

Every times when I re-index the graph on my iOS device, it shows the following message.

IMG_A91F3F13D74A-1

@cnrpman cnrpman changed the title Renaming a page causes changes to not be saved to file Renaming a page between capitalization causes changes to not be saved to file Jun 6, 2023
@cnrpman cnrpman added the fs File system label Jun 6, 2023
@cnrpman
Copy link
Collaborator

cnrpman commented Jun 6, 2023

@situ2001 Basically need to check how is it created.
AFAIK, a tricky & related case is FS event on macOS isn't fired when renaming file between capitalization.

@cnrpman cnrpman added the need-to-reproduce More clues are required to reproduce the issue. label Jun 6, 2023
@cnrpman cnrpman changed the title Renaming a page between capitalization causes changes to not be saved to file Old file not deleted when renaming page between capitalization changes and cause conflict Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filenames fs File system mobile:ios need-to-reproduce More clues are required to reproduce the issue. page-rename
Projects
Status: 🗄 Backlog
Development

No branches or pull requests

4 participants