Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] registerUIItem for pagebar stops to work #9275

Open
1 of 2 tasks
imrickysu opened this issue Apr 30, 2023 · 2 comments
Open
1 of 2 tasks

[API] registerUIItem for pagebar stops to work #9275

imrickysu opened this issue Apr 30, 2023 · 2 comments

Comments

@imrickysu
Copy link

Search first

  • I searched and no similar issues were found

What Happened?

Regression issue: logseq.App.registerUIItem for pagebar doesn't work anymore.

My plugin (on-this-day) used to register pagebar button and it worked well. logseq.App.registerUIItem("pagebar", ...)

Screenshot 2023-04-30 at 08 41 53

In recent builds (0.9.4) this button doesn't show up. Logseq launching doesn't report errors.

Screenshot 2023-04-30 at 08 48 16

If I change the button to toolbar, the original feature works as expected. logseq.App.registerUIItem("toobar", ...)

Screenshot 2023-04-30 at 08 50 00

Reproduce the Bug

  1. Install on-this-day plugin from market place

Screenshot 2023-04-30 at 08 56 22

  1. Go to Settings -> plugins -> On This Day, enable enableJump, set jumpButtonPosition to toolbar, save, restart logseq

Screenshot 2023-04-30 at 08 51 32

  1. Observe the previous and next button shows up on the side of the on-this-day monument icon

  2. Go to Settings -> plugins -> On This Day, enable enableJump, set jumpButtonPosition to pagebar, save, restart logseq

Screenshot 2023-04-30 at 08 51 41

  1. Observe that the icons doesn't show up on pagebar

Expected Behavior

Two buttons should show up on top right of the page

Screenshots

No response

Desktop or Mobile Platform Information

MacOS 13.3.1
Desktop version 0.9.4

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@cnrpman
Copy link
Collaborator

cnrpman commented May 11, 2023

cc. @xyhp915
Config of the plugin logseq-on-this-day to reproduce the issue
image

https://github.com/imrickysu/logseq-plugin-on-this-day/blob/main/index.js#L429-L439

@cnrpman cnrpman added the ux label May 11, 2023
@cnrpman
Copy link
Collaborator

cnrpman commented May 12, 2023

I found the pagebar UI item is still displayed on the secondary window if have a new window created (cmd+n)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants