-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host field is unconditionally overwritten #61
Comments
+1, what we can also do is have a |
+1 |
Is there a workaround for this? I've been experiencing this while trying to setup a centralized logging solution for a few of my applications. |
what do y'all think of #68? this PR keeps the current behaviour but adds two configuration options (with terrible names, I accept suggestions) that allow you to override the default target for both remote host and request headers information. |
let's merge it !!! |
this has been solved by #68 |
It seems the http input unconditionally saves the remote host into the
host
field after the codecs are applied. This is fine with e.g. a plain codec but problematic with e.g. a json codec where the event payload might contain ahost
field itself.I suggest the http input starts behaving like e.g. the tcp input, which only populates the
host
field if it's unset. Quoting tcp.rb:(One could argue that
event.get(HOST_FIELD)
should rather beevent.include?(HOST_FIELD)
to deal with the corner case that the host field is set to a non-truthy value.)The text was updated successfully, but these errors were encountered: