Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin needs some refactoring love #11

Open
purbon opened this issue Sep 17, 2015 · 0 comments
Open

Plugin needs some refactoring love #11

purbon opened this issue Sep 17, 2015 · 0 comments

Comments

@purbon
Copy link

purbon commented Sep 17, 2015

Hi,
while adding test to this plugin I realised the way the code is setup this days makes testing super hard, especially things like:

 public
  def register
    require "ffi-rzmq"
    require "logstash/util/zeromq"
    self.class.send(:include, LogStash::Util::ZeroMQ)

should be skip, otherwise there is no real option to unit test this and always need to have a working zeromq installation.

Error checking and context initialization and termination should be rearranged properly to, so it fits with http://zeromq.org/whitepapers:0mq-termination recommendations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@purbon