Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLQ support #109

Open
RashmiRam opened this issue Mar 19, 2020 · 1 comment · May be fixed by #110
Open

DLQ support #109

RashmiRam opened this issue Mar 19, 2020 · 1 comment · May be fixed by #110

Comments

@RashmiRam
Copy link

We use http output plugin to push the events to our own java service and we wanted to retry at later time/push failed events to separate outputs in case of 404 or 401 or 403 from our java service. But, currently there is no way to capture the failed events.

I see that DLQ is already supported in elasticsearch output plugin. I suppose DLQ support in http output is also possible without major changes. I am more than happy to raise a PR for the same if we decide to include the support for DLQ
@andsel
Copy link

andsel commented Mar 19, 2020 •
edited

Hi @RashmiRam the desire is to use DLQ in more output other than Elasticsearch output. So if you want to contribute with a PR to the output http would be awesome.

RashmiRam added a commit to RashmiRam/logstash-output-http that referenced this issue Mar 23, 2020
@RashmiRam
Added support for DLQ
93542f9 
1. Used the same logic as elasticsearch output plugin to find out if dlq is enabled or not
[execution_context? && execution_context.dlq_writer? && execution_context.dlq_writer is not a dummy writer?]

2. if dlq is enabled, send it to dlq_writer or log and drop the the events otherwise.

Fixes logstash-plugins#109

Signed-off-by: RashmiRam <rashmi.ramanathan@freshworks.com>
@RashmiRam RashmiRam linked a pull request Mar 23, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for DLQ RashmiRam/logstash-output-http
2 participants
@andsel @RashmiRam