feat(console): unsaved changes alert #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyijun
requested review from
wangsijie,
IceHe,
charIeszhao,
gao-sun,
darcyYe and
simeng-li
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/package.json | 📈 +25 Bytes |
| packages/console/src/components/ConfirmModal/index.tsx | 📈 +45 Bytes |
| packages/console/src/components/UnsavedChangesAlertModal/index.tsx | 📈 +2.04 KB |
| packages/console/src/pages/ApiResourceDetails/index.tsx | 📈 +150 Bytes |
| packages/console/src/pages/ApplicationDetails/components/AdvancedSettings.tsx | 📈 +502 Bytes |
| packages/console/src/pages/ApplicationDetails/components/Settings.tsx | 📈 +343 Bytes |
| packages/console/src/pages/ApplicationDetails/index.tsx | 📈 +161 Bytes |
| packages/console/src/pages/SignInExperience/index.tsx | 📈 +69 Bytes |
| packages/console/src/pages/SignInExperience/tabs/BrandingTab.tsx | 📈 +829 Bytes |
| packages/console/src/pages/SignInExperience/tabs/OthersTab.tsx | 📈 +828 Bytes |
| packages/console/src/pages/SignInExperience/tabs/SignInMethodsTab.tsx | 📈 +785 Bytes |
| packages/phrases/src/locales/en.ts | 📈 +180 Bytes |
| packages/phrases/src/locales/zh-cn.ts | 📈 +152 Bytes |
| pnpm-lock.yaml | 📈 +1.27 KB |
gao-sun
requested changes
Jul 4, 2022
xiaoyijun
force-pushed
the
xiaoyijun-log-2257-unsaved-alert
branch
from
c0d76c7
to
014a649
Compare
xiaoyijun
force-pushed
the
xiaoyijun-log-2257-unsaved-alert
branch
from
014a649
to
8b3eecb
Compare
wangsijie
reviewed
Jul 5, 2022
wangsijie
approved these changes
Jul 5, 2022
gao-sun
reviewed
Jul 5, 2022
packages/console/src/components/UnsavedChangesAlertModal/index.tsx
Outdated
Show resolved
Hide resolved
gao-sun
reviewed
Jul 5, 2022
gao-sun
approved these changes
Jul 5, 2022
IceHe
pushed a commit
that referenced
this pull request
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat(console): unsaved changes alert
Note
React-Router V6 has removed the
useBlocker&usePromptAPI, so I implemented a workaround solution to support this feature.FYI: remix-run/react-router#8139
Related PRs
Testing