Migrated travis ci to github actions #263
Conversation
.github/workflows/build.yml
Outdated
| on: [push] | ||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-18.04 |
There was a problem hiding this comment.
Why an old version of Ubunutu? Is this the most up to date version that GH action supports?
There was a problem hiding this comment.
according to https://github.com/actions/virtual-environments and https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
we can update to Ubuntu 20.04
| - name: Install | ||
| run: | | ||
| echo 'Install on ' ${GITHUB_REF##*/} | ||
| ./mvnw install -DskipTests -Dgpg.skip |
There was a problem hiding this comment.
Why not run the unit tests here? Do we run them somewhere else?
There was a problem hiding this comment.
well, I did the same flow as travis has with only install, for example https://github.com/logzio/sawmill/blob/master/.travis.yml#L13
There was a problem hiding this comment.
That looks like a bug. Someone, somewhere, should be running the unit tests.
There was a problem hiding this comment.
I just checked some merged PR and it has only install and deploy stages https://travis-ci.org/github/logzio/sawmill/builds/753004033
If we want to have also test run I can add this stage if no objections.
There was a problem hiding this comment.
Let's finish migrating to GH actions as is. Once this works, let's enable tests as well.
Improved github action migration
Added build variable resolving via github secrets
Fixed RELEASING doc according to new implementation
Added new codesigning key
|
@barakm updated |
Migrated travis ci to github actions. There are several thing we need to do:
settings.xmlwith creds