Problem w change in media query processing

[mschipperheyn]

In this merge b832bb2 the workings of styled flexbox grid have been changed.

I don't think this is a good choice, and I'm having problems in my personal project because of this.

First, the merge changes em processing to px processing. This is not the way flexboxgrid (https://github.com/kristoferjoseph/flexboxgrid/blob/master/src/css/flexboxgrid.css) processes units and makes react-styled-flexboxgrid actually not flexboxgrid anymore.

The +1 on the min width was presumably the reason to switch to pixels, since this is the common way to prevent media query problems. On my project I'm seeing single columns on two <Col xs={12} sm={6} [...] because of this.

In short, this can't be right.

[LoicMahieu]

Hi
First, thanks for your feedback.
The motivation behind #13 has not been explain and it's a shame ;) I didn't handle it directly so I can't explain clearly why we did this. I wasn't confortable with the fact to go to pixels values too.

I will come back here next week with the explanation and we will discuss about it.

[mschipperheyn]

Perhaps you could add the breakpoint unit type to the theme definition so that people can customize it, if they want that, but otherwise functionality is preserved

[tlvenn]

As illustrated in the following article, em should be used in breakpoints to work properly cross-browser and support users changing their browsers font-size

https://zellwk.com/blog/media-query-units/

[zentuit]

If you read the comments in that article, you'll see evidence from folks that the author is incorrect in his conclusions - specifically the Safari not reporting px the same as the other browsers when zooming. If you look at the animated gif in his article, you'll see that the px test matches the other browsers' tests; its the em/rem tests that differ on Safari. Px based queries get consistent results across browsers when zooming.

I just tested this on Chrome and Safari and both Chrome and Safari's media query with px behave the same. You can try with http://codepen.io/blyne/pen/mPwmvX (I changed from the 400px/25em/25rem to 640px/40em/40rem)

[tlvenn]

Good point @zentuit , i have overlooked the comments.

A media query using em or rem (e.g. max-width) is based on the size of the viewport.
The viewport isn't affected by the elements inside of it even if the elements are larger than the viewport.
CSS gives us control over the font sizes of the elements, but not the viewport.

I guess that would explain the switch from em to px ?

[mschipperheyn]

Let's also not forget that this library is supposed to be a react implementation of flexboxgrid, which clearly goes the "em" way

[splars]

Thanks for creating this lib, I think it's really easy to use. Is there any plan to deal with this issue?

[LoicMahieu]

Sorry to being back late.
@mschipperheyn @splars I agree with you, this library is supposed to be kind of port of flexboxgrid and I want to follow their implementation.

I reverted the commit in #35 and it is published v1.1.0

Thanks