Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion for clear style #54

Open
goldenbearkin opened this issue Jun 16, 2017 · 1 comment
Open

suggestion for clear style #54

goldenbearkin opened this issue Jun 16, 2017 · 1 comment

Comments

@goldenbearkin
Copy link

goldenbearkin commented Jun 16, 2017

if dont support below responsively,

<Row start="xs" end="lg">

why don't make it defaults to "xs" and becomes

<Row start>

Above looks a lot clear, less boilerplate !
now, everytime i need to write

<Row start="xs">
@goldenbearkin goldenbearkin changed the title <Suggest> clear style suggestion for clear style Jun 16, 2017
@LoicMahieu
Copy link
Owner

Mmh... Yes maybe it could be useful.

We could consider each prop of this kind as xs when strictly equal to true. It will produce a media query with min-width: 0, so the default.

All properties of this kind:

  • start
  • center
  • end
  • top
  • middle
  • bottom
  • around
  • between
  • first
  • last

I dont think that end === true should be interpreted to lg. It does not make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants