Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove text-align #90

Closed
Dremora opened this issue Dec 13, 2017 · 1 comment
Closed

Remove text-align #90

Dremora opened this issue Dec 13, 2017 · 1 comment

Comments

@Dremora
Copy link
Contributor

Dremora commented Dec 13, 2017

Currently setting a center or end property on Row also sets text-align. This property is not responsible for the layout (that's what justify-content is for), but what's worse, it gets inherited by all children, causing unwanted effects. I still expect text to be left-aligned even when containing column is aligned to the right.
@Dremora Dremora mentioned this issue Dec 13, 2017
Merged
@LoicMahieu
Copy link
Owner

Hi @Dremora
Thanks for sharing your experience.

Yes I make sense that Row should not change text alignement. It was based on the behavior of flexboxgrid.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dremora @LoicMahieu