Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize different core library for .NET Core vs. NET Framework #20

Closed
osman-turan opened this issue Mar 9, 2019 · 0 comments
Closed

Serialize different core library for .NET Core vs. NET Framework #20

osman-turan opened this issue Mar 9, 2019 · 0 comments
Assignees
@osman-turan
Labels
bug Something isn't working

Comments

@osman-turan
Copy link
Collaborator

To support both .NET Core and .NET Framework, we need to serialize either mscorlib for .NET Framework and System.Runtime for .NET Core as core library. Ideally this decision should be taken at runtime without compile-time directives.
@osman-turan osman-turan added the bug Something isn't working label Mar 9, 2019
@osman-turan osman-turan self-assigned this Mar 9, 2019
osman-turan added a commit that referenced this issue Mar 9, 2019
@osman-turan
Serialize different core library for .NET Core and .NET Framework
e6f1e84 
This commit detects framework at runtime and serialize required core library accordingly.

Fixes: #20
@osman-turan osman-turan mentioned this issue Mar 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osman-turan osman-turan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osman-turan