-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ππ οΈ for Luxembourg π±πΊ flag association #925
Conversation
[fix] Flag of Luxembourg
UPD: I've double-checked -- Lebanese Arabic should show the Arabic league flag,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the Hungarian from this, please?
src/meta.ts
Outdated
@@ -30,4 +30,6 @@ export const DEFAULT_LOCALE_COUNTRY_MAP = { | |||
ja: 'ja', | |||
es: 'es', | |||
vi: 'vn', | |||
hu: 'hu', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the Hungarian flag should be available by default:
https://github.com/lokalise/i18n-ally/blob/main/src/utils/flags.ts#L111
https://github.com/lokalise/i18n-ally/blob/main/res/flags/hu.svg
If it's not showing, then open a separate issue for it, please
hu: 'hu', |
[fix] for #881