Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add next-intl framework #934

Merged
merged 9 commits into from
Aug 27, 2023
Merged

feat: Add next-intl framework #934

merged 9 commits into from
Aug 27, 2023

Conversation

amannn
Copy link
Contributor

@amannn amannn commented May 22, 2023 •
edited

Closes #820

My.Movie.mp4

amannn
amannn commented May 22, 2023
View reviewed changes
src/frameworks/next-intl.ts
`{t('${keypath}')}`,
`t('${lastSegment}')`,
`t('${keypath}')`,
]
Copy link
Contributor Author

@amannn amannn May 22, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to consider an existing namespace in this function, to automatically remove the namespace from the suggestion?

Also if the component uses a given namespace, it would be great if that would show up as a default when entering a key. Is this possible?

If not, I guess this is good enough!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespaces were hard to implement with the current architecture. Let's get the framework running as is now

@amannn amannn marked this pull request as ready for review May 22, 2023 10:21
@amannn amannn mentioned this pull request May 23, 2023
Closed
@amannn
Copy link
Contributor Author

amannn commented Jul 13, 2023

@terales I noticed there was a release of i18n-ally recently. Is there anything I can do to move forward with this PR? Thank you!

@FelipeJz
Copy link

Any progress with this?

@Arno500
Copy link

Arno500 commented Aug 1, 2023 •
edited

I also am really interested in this framework, would be great to have a quick review ;)

@amannn
Copy link
Contributor Author

amannn commented Aug 2, 2023

@terales I've just rebased this PR on the latest changes from main. Any chance this could get released?

@amannn amannn mentioned this pull request Aug 2, 2023
Merged
@terales
Copy link
Collaborator

terales commented Aug 2, 2023 via email

@laurent512
Copy link

Hi , thanks for the great work !
Would you have update on that ? :)

@visualcookie
Copy link

What is the update cycle to this? This is really needed.
@amannn Mind sharing how to maybe get this into VSCode right now without waiting for long?

@amannn
Copy link
Contributor Author

amannn commented Aug 25, 2023

@visualcookie You can check out this branch and run a dev build of the extension: https://github.com/lokalise/i18n-ally/wiki/Contribute#extension-development

terales
terales approved these changes Aug 27, 2023
View reviewed changes
src/frameworks/next-intl.ts
`{t('${keypath}')}`,
`t('${lastSegment}')`,
`t('${keypath}')`,
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespaces were hard to implement with the current architecture. Let's get the framework running as is now

@terales terales merged commit e25e1cd into lokalise:main Aug 27, 2023
3 checks passed
huacnlee pushed a commit to huacnlee/i18n-ally that referenced this pull request Aug 28, 2023
@amannn @huacnlee
feat: add next-intl framework (lokalise#934)
f778d8b 
* WIP

* Load framework

* Add VSCode setting

* Basic PoC

* Cleanup

* Add preferred keystyle

* Clean up

* All permutations for keypaths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terales terales terales approved these changes

@kibertoad kibertoad Awaiting requested review from kibertoad kibertoad is a code owner

@anilkk anilkk Awaiting requested review from anilkk

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for next-intl
6 participants
@amannn @FelipeJz @Arno500 @terales @laurent512 @visualcookie