Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas is appended to body, leaves image if an error occurs. #75

Closed
Luke-SF opened this issue Jul 8, 2015 · 4 comments
Closed

Canvas is appended to body, leaves image if an error occurs. #75

Luke-SF opened this issue Jul 8, 2015 · 4 comments

Comments

@Luke-SF
Copy link

Luke-SF commented Jul 8, 2015

I noticed the script appends canvas to document.body element... Why?

document.body.appendChild(this.canvas)

If there's an error such as Uncaught SecurityError: Failed to execute 'getImageData' on 'CanvasRenderingContext2D' it leaves the image at bottom of the page.

@jlabresh1
Copy link

I noticed this too. +1 to this

@ruthlessfish
Copy link

+1

@rafgeekee
Copy link

@lokesh
Copy link
Owner

lokesh commented Jul 15, 2019

This issue was eventually resolved. Color Thief now does not append the <canvas> tag to the DOM: https://github.com/lokesh/color-thief/pull/150/files

@lokesh lokesh closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants