Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caption links handlers doesn't trigger #635

Closed
installero opened this issue Jan 17, 2019 · 1 comment
Closed

Caption links handlers doesn't trigger #635

installero opened this issue Jan 17, 2019 · 1 comment

Comments

@installero
Copy link

installero commented Jan 17, 2019

This code here prevents any other handlers attached to caption links to trigger:

        .find('a').on('click', function(event) {
          if ($(this).attr('target') !== undefined) {
            window.open($(this).attr('href'), $(this).attr('target'));
          } else {
            location.href = $(this).attr('href');
          }
        });

What version of Lightbox2 you are using?

2.10.0

Which browsers and operating systems have you seen the issue on?

FireFox 64.0 on Ubuntu 16.04 (I believe this doesn't matter)

What are the steps to reproduce the bug?

Here's an example:

https://gist.github.com/installero/d5028228d903928f28afad8f6c0f6d60

Do you have link to a live site where the bug is visible? or can you post relevant HTML, CSS, and Javascript?

Demo: https://gracious-hopper-3dfc38.netlify.com/

@lokesh
Copy link
Owner

lokesh commented Apr 22, 2019

Fixed in v2.11.0: https://github.com/lokesh/lightbox2/releases/tag/v2.11.0

@lokesh lokesh closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants