std::filesystem, epee cleanups, wallet_api cleanups #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch several builds to sid, and updates the linux clang build to 11.
Converts all use of boost::filesystem to std::filesystem. For macos and potentially other exotic systems where std::filesystem isn't available, we use ghc::filesystem instead (which is a drop-in replacement for std::filesystem, unlike boost::filesystem). This also greatly changes how we handle filenames internally by holding them in filesystem::path objects as soon as possible (using fs::u8path()), rather than strings, which avoids a ton of issues around unicode filenames. As a result this lets us drop the boost::locale dependency on Windows along with a bunch of messy Windows ifdef code, and avoids the need for doing gross boost locale codecvt calls.
- Remove some useless epee functions, and add deprecated markers to ones that have good replacements already. - Don't use boost::lexical_cast when std::to_string or direct stream output can be used just as well. - Get rid of dumb epee "include_base_utils.h" header
Payment ID for address books are no longer supported (should be using integrated addr instead) Remove deprecated functions taking a `bool` testnet type (they should be passing the network type enum instead).
Don't "using namespace std" Make reference/pointer sigils more consistent.
This ends epee's include pollution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces boost::filesystem with std::filesystem (or, when not supported, the ghc::filesystem drop-in replacement, the same thing we use for lokinet).
Also removes some obsolete methods from epee that have direct lokimq or tools::* replacements, moves all epee includes under an "epee/" subdirectory, removes a bunch of useless boost::lexical_cast's (unclear why these were ever used instead of std::to_string).
This also brings wallet_api up to speed: renaming the "Monero" namespace to "Wallet", removing deprecated functions, and updates it for the above.