Error when trying to sign using a watch-only wallet #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cli wallet was correctly refusing to sign, but the RPC wallet (and wallet2 internally) allowed it and would sign with the all-0s address, which of course is invalid and fails to verify. This now throws if attempting to do so to get an error returned to the rpc endpoint. Other minor changes here: - make wallet2::verify static (verification doesn't depend on the wallet instance at all). - Add documentation for wallet2 sign/verify - Slight DRY of wallet2::sign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli wallet was correctly refusing to sign, but the RPC wallet (and
wallet2 internally) allowed it and would sign with the all-0s address,
which of course is invalid and fails to verify. This now throws if
attempting to do so to get an error returned to the rpc endpoint.
Other minor changes here:
instance at all).