Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public chat duplicate message fix #508

Merged
merged 3 commits into from
Sep 24, 2019
Merged

Public chat duplicate message fix #508

merged 3 commits into from
Sep 24, 2019

Conversation

Mikunj
Copy link

@Mikunj Mikunj commented Sep 13, 2019

This PR makes it so any similar messages fetched through the public chat will be ignored if:
The same author posted the message, The message has the same text AND the message was sent within 10 seconds.

This will alleviate the display of spam somewhat but is not the perfect counter measure as someone could spam the same message every 10 seconds.

Fixes #504

Copy link

@sachaaaaa sachaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fine fix👌
Just one little suggestion, but after that ship it :)

js/modules/loki_public_chat_api.js Outdated Show resolved Hide resolved
@sachaaaaa sachaaaaa merged commit a3d6778 into oxen-io:clearnet Sep 24, 2019
@Mikunj Mikunj deleted the duplicate-message-fix branch November 14, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate messages aren't being filtered out
4 participants