Markdown #516
Markdown #516
Conversation
|
I do want to add some more markdown elements per https://support.discordapp.com/hc/en-us/articles/210298617-Markdown-Text-101-Chat-Formatting-Bold-Italic-Underline- |
|
Looks like "grunt unit tests" are failing, any ideas on how to include |
| .use(remarkRecommended) // better cross browser support? | ||
| .use(remarkHtml); // and finally convert to HTML | ||
|
|
||
| window.markdoneHTMLConverter = markdown => { |
| // this does allow `<b>bold example</b>` to work | ||
| .use(remarkStrip) | ||
| .use(remarkRecommended) // better cross browser support? | ||
| .use(remarkHtml); // and finally convert to HTML |
There was a problem hiding this comment.
Would it be possible to use window.markDownHTMLConverter directly?
There was a problem hiding this comment.
yes, I think this was done before I understood how preload.js/window worked
| if (markdown) { | ||
| // DO NOT ALLOW users/servers to slip in their own custom HTML | ||
| const file = mdEngine.processSync(markdown); | ||
| text = String(file); |
There was a problem hiding this comment.
Is there any way we can do the markdown processing at a lower level? There seems to be some duplicated logic between public and private messages.
Why not emit the raw message here and leave the markdown handling to the message.js model?
There was a problem hiding this comment.
No lower level than when it comes in from the server TBH. Per the comment, you need to protect from a malicious server from injecting malicious HTML into the feed.
Also public chat has a separate pipeline to keep it compatible with the appdotnet ecosystem (like the irc bridges, etc). This requires no markdown in the text field. The duplicate logic is contained to the libloki_markdown library itself.
| @@ -518,9 +525,12 @@ class LokiPublicChannelAPI { | |||
| } | |||
|
|
|||
| async pollOnceForMessages() { | |||
| // mark sure send() can access this object instance | |||
| const ref = this; | |||
There was a problem hiding this comment.
This looks like a binding issue?
Where is that function send() that needs to access this instance?
There was a problem hiding this comment.
remanent from a previous version, I think we can remove these 2 lines
| let processedText = text; | ||
| if (hasMarkdown(text)) { | ||
| // if we detect markDown, convert to HTML | ||
| processedText = window.markdoneHTMLConverter(text); |
|
Going to close this for now to clean up the PRs. |
Work in progress, do not merge. Posting per Maxim's request.
Public chat works
Note to self works
conversation last message works
outgoing message works in somecases
still need to redo how private conversation work with it; going to nothing with markdown on the senders side and move the detection to the receivers side
also needs some cleanup ofc
supports the following markdown:
does not handle nesting of em in strong and visa versa
plan to add more from https://support.discordapp.com/hc/en-us/articles/210298617-Markdown-Text-101-Chat-Formatting-Bold-Italic-Underline-