allow running lokinet as root on windows #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
($PROGRAMDATA/.lokinet/lokinet.ini) - oops forgot to eat my own command line args
despair86
commented
Sep 16, 2020
despair86
commented
Sep 16, 2020
despair86
commented
Sep 16, 2020
| @@ -329,8 +332,7 @@ lokinet_main(int argc, char* argv[]) | |||
| options.add_options()("v,verbose", "Verbose", cxxopts::value<bool>()) | |||
| #ifdef _WIN32 | |||
| ("install", "install win32 daemon to SCM", cxxopts::value<bool>())( | |||
| "remove", "remove win32 daemon from SCM", cxxopts::value<bool>())( | |||
| "win32-daemon", "do not use interactively", cxxopts::value<bool>()) | |||
There was a problem hiding this comment.
we no longer need the entry in cxxopts..................
despair86
commented
Sep 16, 2020
| ReportSvcStatus(SERVICE_START_PENDING, NO_ERROR, 3000); | ||
| // SCM clobbers startup args, regenerate them here | ||
| argc = 2; | ||
| argv[1] = "c:/programdata/.lokinet/lokinet.ini"; |
There was a problem hiding this comment.
.....................because we eat it here: becomes [path to lokinet] [path to config file]
TODO: for internal testing use $ALLUSERSPROFILE/Appplication Data/.lokinet (programdata didn't exist yet)
|
this fixed the service startup crash: scm kept chewing up the command line arguments |
|
indeed after this and #1348 i am no longer making much of an effort to deal with pre-windows 8 |
majestrate
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by relocating to (
$PROGRAMDATA/.lokinet)