-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix build for travis #705
Conversation
d990ade
to
51244af
Compare
38e9e22
to
3a3343e
Compare
You removed:
|
Copy paste is not unification. |
How is it unified? beyond sharing some (unused!) environment variables, what value does it add?
sort of goes against what travis provides. cross platform build could be part of the matrix build, and I want to add actual macOS and windows builds here, so we don’t regress on those platforms.
I don’t see how the current build does that either
So could this one. |
b33aff3
to
f7ea682
Compare
Part of me really likes ditching that tightly wound system, so I don't deeply care one way or another. Your expertise here is appreciated but I did want to communicate what the advantages of the existing system over this (because it was a bit of a rabbit hole for me to figure out and clearly not obvious).
The idea would be having more staff that can pitch in and work cross-project, so we have less dependencies on specific people.
Agreed, anything can be improved. Travis only having Xenial is painful though. |
Also thought mac/win was running on gitlab-ci but looks like that's all disabled. Even had to remove alpine, so if you have any time to look at that one too, it's also very easy to get macos going over there (The office has a mac runner). And with our windows build VM, we can set up a windows runner too. |
It looks like this branch (awkwardly) isn’t triggering CI anymore. Will take a look later today. |
cccd2da
to
4359bb8
Compare
No description provided.