Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix build for travis #705

Merged
merged 15 commits into from
Jul 15, 2019
Merged

Conversation

michael-loki
Copy link
Contributor

No description provided.

.travis.yml Outdated Show resolved Hide resolved
@neuroscr
Copy link
Contributor

You removed:

  • having a unified travis-ci testing framework (from bitcoincore inherited through Monero) across all loki projects (but I'm not sure any one desires this beyond me)
  • builder and host agnostism (and testing cross platform building)
  • No reliance on timestamps (previous macos sdk image has specifically modified build tools, we're working on updating this image to be newer, you could have helped the loki project too if you had worked on that)
  • The previous system can be made to make builds deterministic but we haven't gotten around to making the dependency package files

@michael-loki
Copy link
Contributor Author

Copy paste is not unification.

@michael-loki
Copy link
Contributor Author

having a unified travis-ci testing framework (from bitcoincore inherited through Monero) across all loki projects (but I'm not sure any one desires this beyond me)

How is it unified? beyond sharing some (unused!) environment variables, what value does it add?

builder and host agnostism (and testing cross platform building)

sort of goes against what travis provides. cross platform build could be part of the matrix build, and I want to add actual macOS and windows builds here, so we don’t regress on those platforms.

No reliance on timestamps

I don’t see how the current build does that either

The previous system can be made to make builds deterministic but we haven't gotten around to making the dependency package files

So could this one.

@neuroscr
Copy link
Contributor

Part of me really likes ditching that tightly wound system, so I don't deeply care one way or another. Your expertise here is appreciated but I did want to communicate what the advantages of the existing system over this (because it was a bit of a rabbit hole for me to figure out and clearly not obvious).

what value does [consistency across project] add?

The idea would be having more staff that can pitch in and work cross-project, so we have less dependencies on specific people.

So could this one.

Agreed, anything can be improved. Travis only having Xenial is painful though.

@neuroscr
Copy link
Contributor

Also thought mac/win was running on gitlab-ci but looks like that's all disabled. Even had to remove alpine, so if you have any time to look at that one too, it's also very easy to get macos going over there (The office has a mac runner).

And with our windows build VM, we can set up a windows runner too.

@michael-loki
Copy link
Contributor Author

It looks like this branch (awkwardly) isn’t triggering CI anymore. Will take a look later today.

@michael-loki michael-loki merged commit 554e648 into oxen-io:master Jul 15, 2019
@michael-loki michael-loki deleted the travis_matrix branch July 15, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants