Add rpc call to get current addresses for our node #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-loki
commented
Oct 7, 2019
| ("h,help", "help", cxxopts::value<bool>()) | ||
| ("j,json", "output in json", cxxopts::value<bool>()) |
There was a problem hiding this comment.
based on feedback from @jagerman, the non-json output isn't that useful, so make it the default.
michael-loki
force-pushed
the
rcutil_curl
branch
from
8fe26b9
to
b9a3ca9
Compare
majestrate
reviewed
Oct 7, 2019
llarp/config/config.cpp
Outdated
Comment on lines
481
to
485
| #ifdef _WIN32 | ||
| fs::path homedir = fs::path(getenv("APPDATA")); | ||
| #else | ||
| fs::path homedir = fs::path(getenv("HOME")); | ||
| #endif |
|
looks like ci wants the package: |
michael-loki
force-pushed
the
rcutil_curl
branch
from
50850e9
to
6d1769b
Compare
|
we should make it look for the libcurl in |
|
Glad to see this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #856
Also, add the ability to use libcurl to hit the jsonrpc endpoint (the libcurl dependency is optional, if it's not available on the system, support simply isn't compiled in).