Null mutex clarity (via comments / log statement) #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-loki
approved these changes
Oct 11, 2019
llarp/util/thread/threading.hpp
Outdated
| @@ -31,9 +31,16 @@ namespace llarp | |||
| namespace util | |||
| { | |||
| /// a mutex that does nothing | |||
| /// | |||
| /// this exists to convert "old" mutexes that may no longer be necessary | |||
There was a problem hiding this comment.
nit: I would note that previously they were real mutexes too.
There was a problem hiding this comment.
added even more comments in a3c48e2
|
|
notlesh
force-pushed
the
null_mutex_clarity
branch
from
86635f5
to
46fe64c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving some additional breadcrumbs for anyone who stumbles across NullMutex might help it achieve its purpose.