Add numNodesKnown to llarp.admin.dumpstate RPC endpoint #862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the number of nodes in the
nodedb
to thellarp.admin.dumpstate
endpoint.It might be better / more consistent to add an
ExtractStatus()
method tonodedb
, though there doesn't seem to be much else innodedb
we might want to know.Also note that
num_loaded()
is going to acquire thenodedb
'saccess mutex
; would this be problematic?