Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numNodesKnown to llarp.admin.dumpstate RPC endpoint #862

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Oct 11, 2019

This adds the number of nodes in the nodedb to the llarp.admin.dumpstate endpoint.

It might be better / more consistent to add an ExtractStatus() method to nodedb, though there doesn't seem to be much else in nodedb we might want to know.

Also note that num_loaded() is going to acquire the nodedb's access mutex; would this be problematic?

@majestrate
Copy link
Contributor

the access mutex acquisition should not be a problem

@majestrate majestrate merged commit 03ca67e into oxen-io:dev Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants