Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devendor libsodium #883

Merged
merged 6 commits into from Oct 29, 2019

Conversation

@majestrate
Copy link
Collaborator

majestrate commented Oct 29, 2019

No description provided.

majestrate added 2 commits Oct 29, 2019
@majestrate majestrate requested a review from jagerman Oct 29, 2019
majestrate added 3 commits Oct 29, 2019
@@ -51,7 +51,7 @@ if (UNIX)
# import pkg-config
find_package(PkgConfig QUIET)
if (PKG_CONFIG_FOUND)
pkg_check_modules(sodium_PKG QUIET libsodium)
pkg_check_modules(sodium_PKG QUIET libsodium>=1.0.16)

This comment has been minimized.

Copy link
@jagerman

jagerman Oct 29, 2019

Collaborator

I think this can be libsodium>=${PACKAGE_FIND_VERSION} to pass through the version given in the outer find_package() call.

@majestrate majestrate merged commit 6d08838 into loki-project:dev Oct 29, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.