Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send ports #146

Merged
merged 6 commits into from Jun 6, 2019
Merged

Send ports #146

merged 6 commits into from Jun 6, 2019

Conversation

BeaudanBrown
Copy link
Contributor

Save the IP and port which is now being sent from lokid
Send the IP and port to clients as well

NOTE: Will need to update the integration tests to work with the change from "port" to "storage_port"
msgmaxim/swarm_migration_testing#2

Copy link
Contributor

@sachaaaaa sachaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with just some suggestions to constify a bit further.

httpserver/http_connection.cpp Outdated Show resolved Hide resolved
httpserver/http_connection.cpp Outdated Show resolved Hide resolved
httpserver/http_connection.cpp Outdated Show resolved Hide resolved
@msgmaxim msgmaxim merged commit a77b449 into oxen-io:dev Jun 6, 2019
@BeaudanBrown BeaudanBrown deleted the send-ports branch June 6, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants