Peer testing fix #343
Merged
Peer testing fix #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
msgmaxim
commented
Apr 6, 2020
msgmaxim
commented
- try to reuse the same outgoing connection for peer testing, so we don't have to manually close it
Use connect_remote was causing significant problems with the default pubkey-based routing IDs because the new outgoing connections for reachability would end up replacing the existing SN-to-SN connection due to reusing the same id. This commit includes an update to lokimq to specify that a send/request should be done only on outgoing connections, without needing to open and close new outgoing connections when there is an existing outgoing SN connection to the remote being tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.