Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TX's sitting in the pool should display as locked balance #398

Closed
Doy-lee opened this issue Jan 14, 2019 · 3 comments
Closed

TX's sitting in the pool should display as locked balance #398

Doy-lee opened this issue Jan 14, 2019 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Doy-lee
Copy link
Collaborator

Doy-lee commented Jan 14, 2019

This is most likely a regression. The wallet is aware that there are transactions sitting in the tx pool for itself and notifies as such

Password needed (output received) - use the refresh command

Upon refresh, locked balance is not updated and the wallet on idle will continually ask for a refresh until it is included in a block.

Steps To Reproduce (On a local testnet)

  1. Launch two wallets and a daemon
  2. On wallet A, mine a couple of blocks
  3. On wallet A, transfer to wallet B
  4. Observe wallet B while it is idle, and Password needed (output received) - use the refresh command will appear
  5. Refresh on wallet B, observe that locked balance remains at 0
@Doy-lee Doy-lee added the bug Something isn't working label Jan 14, 2019
@jagerman
Copy link
Member

A pending mempool balance probably shouldn't be included in the locked balance (and, AFAIK, never has been): it isn't actually in the chain and might never make it to the chain. It would, however, be nice to report the pending mempool balance separately, though (something like: Balance: 0.123456789, unlocked balance: 0.123456789, incoming balance: 0.987654321).

@Doy-lee
Copy link
Collaborator Author

Doy-lee commented Jan 24, 2019

Interesting, I was under the impression it used to. The bug here I suppose is requesting a refresh unnecessarily whilst the TX is to be included in a block.

@Doy-lee Doy-lee added the duplicate This issue or pull request already exists label Jul 31, 2019
@Doy-lee
Copy link
Collaborator Author

Doy-lee commented Jul 31, 2019

Closed as duplicate with #644

@Doy-lee Doy-lee closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants