New print_sn_state_changes command #727
Conversation
src/rpc/core_rpc_server.cpp
Outdated
|
|
||
| res.start_height = req.start_height; | ||
| res.end_height = end_height; | ||
| res.total_deregister = 0; |
There was a problem hiding this comment.
Actually don't need to initialise to 0 since the typedef epee::struct_init thingy sets default initialises things it can to 0.
There was a problem hiding this comment.
Good to know, thanks! Changed.
src/rpc/core_rpc_server.cpp
Outdated
| } | ||
|
|
||
| if (!db.get_blocks(req.start_height, end_height - req.start_height, blocks, txs)) { | ||
| MERROR("Could not query block at requested height: " << req.start_height); |
There was a problem hiding this comment.
Instead of MERROR, fill out the error_resp argument so that it gets returned in the json response.
src/daemon/rpc_command_executor.cpp
Outdated
|
|
||
| if (m_is_rpc) | ||
| { | ||
| if (!m_rpc_client->json_rpc_request(req, res, "get_sn_state_changes", "Failed to query blockchain checkpoints")) |
There was a problem hiding this comment.
get_service_node_state_changes so it matches the declaration in core_rpc_server.h and need to update the error message there.
src/daemon/command_server.cpp
Outdated
| m_command_lookup.set_handler( | ||
| "print_sn_state_changes" | ||
| , std::bind(&t_command_parser_executor::print_sn_state_changes, &m_parser, p::_1) | ||
| , "print_sn_state_changes start height [end height]" |
There was a problem hiding this comment.
print_sn_state_changes <start height> [end height]
start height is mandatory so <> notation
|
|
||
| if (!args_list.empty()) | ||
| { | ||
| std::cout << "use: print_sn_state_changes start height [end height]" |
There was a problem hiding this comment.
And here as well
It'd be nice to lookup the usage from the command_handler, but out of scope. Gonna add it to the todo list.
src/rpc/core_rpc_server.cpp
Outdated
| end_height = req.end_height; | ||
| } | ||
|
|
||
| if (!db.get_blocks(req.start_height, end_height - req.start_height, blocks, txs)) { |
There was a problem hiding this comment.
Should handle the case where req.start_height > end_height
There was a problem hiding this comment.
Done.
Also added a + 1 to ensure count is set to 1 when start == end, i.e. when we want to get events for a specific block...
src/rpc/core_rpc_server.cpp
Outdated
| } | ||
| if (tx.type == cryptonote::txtype::state_change) | ||
| { | ||
| const uint8_t hard_fork_version = blocks[i].second.major_version; |
There was a problem hiding this comment.
This is probably what's causing the get_service_node_state_change to fail a lot. The txs and blocks array aren't 1:1. The txs returned from get_blocks looks to be all the transactions spanning across all the blocks requested. So you could call get_transaction_blobs yourself per block so you use the right version for each set of transactions
There was a problem hiding this comment.
Ah that probably explains a lot :)
Thanks!
src/rpc/core_rpc_server.cpp
Outdated
| cryptonote::tx_extra_service_node_state_change state_change; | ||
| if (!cryptonote::get_service_node_state_change_from_tx_extra(tx.extra, state_change, hard_fork_version)) | ||
| { | ||
| // TODO: This seem to be triggered quite often with hf 11 blocks |
There was a problem hiding this comment.
Probably want this log now, just incase, assuming the fix was correct
There was a problem hiding this comment.
Good catch! Uncommented and recompiled, the error logs are not printed anymore.
src/daemon/rpc_command_executor.cpp
Outdated
|
|
||
| std::stringstream output; | ||
|
|
||
| output << "Service Node state Changes (blocks " << res.start_height << "-" << res.end_height << ")" << std::endl; |
There was a problem hiding this comment.
Service Node State Changes
End_height here should be -1 if (res.end_height == sentinel) which by default it gets set to the chain height, so the height is the block you are mining for and not a block that already exists in the blockchain.
Otherwise if it's set, you are grabbing the state changes inclusive of the blocks specified so you don't need the -1.
There was a problem hiding this comment.
Changed logic to set the end_height to current_height - 1 when the sentinel is set.
* new `print_sn_state_changes` command * Address reviews * Fix fetching txs for each blocks * sentinel value is set to current height - 1
* new `print_sn_state_changes` command * Address reviews * Fix fetching txs for each blocks * sentinel value is set to current height - 1
print_sn_state_changes start_height [end_height]start_heightis mandatory,end_heightdefaults to the end of the chain.