Revert to manually serializing checkpoints/quorum #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KV_SERIALIZE doesn't handle non-primitive types well and requires adding in extra deserialize/reserialize code. It's more straightforward to manually serialize the output, rather than add serialization overloads. Furthermore, KV_SERIALIZE doesn't support serializing enums in a sane way.
jagerman
approved these changes
Jul 16, 2019
Doy-lee
added a commit
to Doy-lee/loki
that referenced
this pull request
Aug 17, 2019
KV_SERIALIZE doesn't handle non-primitive types well and requires adding in extra deserialize/reserialize code. It's more straightforward to manually serialize the output, rather than add serialization overloads. Furthermore, KV_SERIALIZE doesn't support serializing enums in a sane way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KV_SERIALIZE doesn't handle non-primitive types well and requires adding
in extra deserialize/reserialize code. It's more straightforward to
manually serialize the output, rather than add serialization overloads.
Furthermore, KV_SERIALIZE doesn't support serializing enums in a sane
way.
@jagerman