Minor ui improvements #1034
Merged
Minor ui improvements #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikunj
approved these changes
Mar 31, 2020
Bilb
reviewed
Mar 31, 2020
Comment on lines
149
to
156
| public async onLogin(passPhrase: string) { | ||
| const trimmed = passPhrase ? passPhrase.trim() : passPhrase; | ||
| const passPhraseTrimmed = passPhrase.trim(); | ||
|
|
||
| try { | ||
| await window.onLogin(trimmed); | ||
| await window.onLogin(passPhraseTrimmed); | ||
| } catch (error) { | ||
| // Increment the error counter and show the button if necessary | ||
| this.setState({ |
There was a problem hiding this comment.
Not an issue with this PR but is that a good idea to trim the passphrase? I mean if a user uses a password with by any luck a space at the end? It's ok for me but we should double check every time we save the password we trim it also.
Otherwise the user might be able to save a password with a space at the end but will never be able to login with it.
There was a problem hiding this comment.
Makes sense. I'll address this in a new PR
Bilb
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIN_HEIGHTand other window params to accommodate modal heightsSessionPasswordPrompt.