Integration tests: Support slower computers/network #1044
Conversation
…h is more reliable
| await app.client.waitForExist( | ||
| ConversationPage.sessionToastJoinOpenGroupSuccess, | ||
| 9000 | ||
| 60 * 1000 |
There was a problem hiding this comment.
the maximum test timeout is currently 30seconds. you want to increase that value too, isn't it? https://github.com/loki-project/session-desktop/pull/1044/files?file-filters%5B%5D=.js#diff-dd50b247dac58a9b47120e5c4f1b2c46R9
There was a problem hiding this comment.
we can reduce these down, I didn't need that high but I could see other running the integration tests (maybe outside devs) may need it.
I'm fine either way tbh.
| @@ -23,25 +23,25 @@ describe('Open groups', function() { | |||
| await common.killallElectron(); | |||
| }); | |||
|
|
|||
| it('works with valid group url', async () => { | |||
| // reduce code duplication to get the initial join | |||
| async function joinOpenGroup(url, name) { | |||
There was a problem hiding this comment.
no, I feel like common shouldn't have functions for specific groups of tests. In fact I'd favor moving some of the constants out of it. I think we should favor smaller cleaner files (even though, I personally have no problem working with bigger ones).
| // wait for toast to appear | ||
| await app.client.waitForExist( | ||
| ConversationPage.sessionToastJoinOpenGroupSuccess, | ||
| 30 * 1000 |
There was a problem hiding this comment.
same as above. current test timeout is 30s https://github.com/loki-project/session-desktop/pull/1044/files?file-filters%5B%5D=.js#diff-dd50b247dac58a9b47120e5c4f1b2c46R9
yarn test-integration-partscommon.page