Rework currencies

[MrIvanPlays]

Closes #49
Closes #40

[MrIvanPlays]

@MrNemo64 @Geolykt

[lokka30]

Thank you very much! Only a few things I could point out to change, the rest is marvelous.

[lokka30]

Would like to hear from @Jikoo @MrNemo64 @Geolykt, if possible. Would be much appreciated :)

[lokka30]

Once we've gathered enough feedback, is this PR ready to merge as-is?

[MrIvanPlays]

Once we've gathered enough feedback, is this PR ready to merge as-is?

Yes.

[Jikoo]

Barring the potential annotation-related changes, looks good to me 👍

[lokka30]

I'll leave about a day until I merge it in case @Geolykt or anyone else wants to review the PR, also leaves more time in case you find an issue that needs to be addressed.

[MrIvanPlays]

@lokka30 Happy now!?

[MrNemo64]

If we rename one of the methods that remove currencies by id, shouldn't all the methods that remove by id also change to match the style of the name? I know is not really necessary but to keep consistency

[MrIvanPlays]

If we rename one of the methods that remove currencies by id, shouldn't all the methods that remove by id also change to match the style of the name? I know is not really necessary but to keep consistency

And I think to myself........ Why the fuck

[lokka30]

@lokka30 Happy now!?

They were just very minor nitpicks, I was happy to begin with :)
Will merge now.

If we rename one of the methods that remove currencies by id, shouldn't all the methods that remove by id also change to match the style of the name? I know is not really necessary but to keep consistency

And I think to myself........ Why the fuck

Consistency can be quite important, we should apply it wherever we can. If it's unfeasible for us to modify something to strive for better consistency then that's completely fine. MrNemo said it wasn't important so we should focus on the next things to do for Treasury instead of trying to iron out every single detail for the moment