-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework currencies #51
Conversation
30b3d51
to
43c4416
Compare
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyParseResult.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyParseResult.java
Outdated
Show resolved
Hide resolved
api/src/test/java/me/lokka30/treasury/api/economy/currency/CurrencyTests.java
Show resolved
Hide resolved
Thank you very much! Only a few things I could point out to change, the rest is marvelous. |
Once we've gathered enough feedback, is this PR ready to merge as-is? |
Yes. |
api/src/main/java/me/lokka30/treasury/api/economy/currency/Currency.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/Currency.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/Currency.java
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/Currency.java
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyManager.java
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyManager.java
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyManager.java
Show resolved
Hide resolved
core/src/main/java/me/lokka30/treasury/plugin/core/command/subcommand/InfoSubcommand.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Barring the potential annotation-related changes, looks good to me 👍
api/src/main/java/me/lokka30/treasury/api/economy/currency/Currency.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/Currency.java
Show resolved
Hide resolved
f17b8b9
to
864c620
Compare
I'll leave about a day until I merge it in case @Geolykt or anyone else wants to review the PR, also leaves more time in case you find an issue that needs to be addressed. |
api/src/main/java/me/lokka30/treasury/api/economy/currency/Currency.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyManager.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyManager.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyManager.java
Outdated
Show resolved
Hide resolved
api/src/main/java/me/lokka30/treasury/api/economy/currency/CurrencyManager.java
Outdated
Show resolved
Hide resolved
@lokka30 Happy now!? |
f881de9
to
63a6d6a
Compare
If we rename one of the methods that remove currencies by id, shouldn't all the methods that remove by id also change to match the style of the name? I know is not really necessary but to keep consistency |
And I think to myself........ Why the fuck |
They were just very minor nitpicks, I was happy to begin with :)
Consistency can be quite important, we should apply it wherever we can. If it's unfeasible for us to modify something to strive for better consistency then that's completely fine. MrNemo said it wasn't important so we should focus on the next things to do for Treasury instead of trying to iron out every single detail for the moment |
Closes #49
Closes #40