Move to Java 8 #419

rmader · 2016-05-24T12:27:08Z

sudheesh001 · 2016-05-24T14:04:44Z

heroku, scalingo failing, needs updates on buildpack

rmader · 2016-05-24T14:22:04Z

Ok, they still use openjdk 1.6. That's deprecated and potentially unsecure anyways

rmader · 2016-05-24T14:23:34Z

@sudheesh001 do you update the build packages? Thanks for testing btw

sudheesh001 · 2016-05-24T14:52:27Z

Bluemix works. http://loklak-server-dispensary-1744.mybluemix.net/

Orbiter · 2016-05-24T14:56:34Z

I just added c6450cc
to support heroku and scalingo. Hints to update the remaining are included in the commit.

Please test heroku and scalingo deployment with this settings. Here is how you find out if the deployed loklak_server is actually running under Java 1.8:

open /api/threaddump.txt on the server where you deployed your test Installation
scroll down to the "ELASTICSEARCH ClUSTER STATS" section
look for jvm.versions.version

Orbiter · 2016-05-24T14:58:03Z

@sudheesh001 Bluemix does NOT work, see http://loklak-server-dispensary-1744.mybluemix.net/api/threaddump.txt according to my hint above: this is still running under Java 1.7

sudheesh001 · 2016-05-24T15:01:09Z

Yup just noticed, somehow it seems to run whereas the others (heroku/scalingo) crash

Orbiter · 2016-05-24T15:15:24Z

We must have a confirmation from the thread dump, otherwise all peers will crash when we switch to Java 1.8

sudheesh001 · 2016-05-24T16:42:15Z

I've moved locally to java8, everything seems to be working but in the ant build i get a line as follows

 [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.7
    [javac] 1 warning

I don't remember seeing them before. The threaddump shows the following

"nodes" : {
    "count" : {
      "total" : 1,
      "master_only" : 0,
      "data_only" : 0,
      "master_data" : 1,
      "client" : 0
    },
    "versions" : [ "2.3.2" ],
    "os" : {
      "available_processors" : 8,
      "allocated_processors" : 8,
      "mem" : {
        "total_in_bytes" : 7478247424
      },
      "names" : [ {
        "name" : "Mac OS X",
        "count" : 1
      } ]
    },
    "process" : {
      "cpu" : {
        "percent" : 21
      },
      "open_file_descriptors" : {
        "min" : 541,
        "max" : 541,
        "avg" : 541
      }
    },
    "jvm" : {
      "max_uptime_in_millis" : 15011,
      "versions" : [ {
        "version" : "1.8.0_92",
        "vm_name" : "Java HotSpot(TM) 64-Bit Server VM",
        "vm_version" : "25.92-b14",
        "vm_vendor" : "Oracle Corporation",
        "count" : 1
      } ],
      "mem" : {
        "heap_used_in_bytes" : 158709544,
        "heap_max_in_bytes" : 559415296
      },
      "threads" : 132
    },
    "fs" : {
      "total_in_bytes" : 328327507968,
      "free_in_bytes" : 8497786880,
      "available_in_bytes" : 8235642880
    },
    "plugins" : [ ]

rmader · 2016-05-25T08:17:28Z

@sudheesh001 i also get this in the master branch. Did you compile the java8 branch or master? As the ant buildfile in master is set to compile to source 1.7 (changed to 1.8 in the java8 branch)

rmader · 2016-05-25T09:00:06Z

I just rebased this branch to include new commits from master, especially the system.properties file

sudheesh001 · 2016-05-25T09:04:29Z

compiled the java8 branch. https://loklakjavajvm8.herokuapp.com/api/threaddump.txt here's the heroku deployment.

sudheesh001 · 2016-05-25T09:07:07Z

heroku log

-----> Fetching set buildpack https://github.com/loklak/heroku_buildpack_ant_loklak.git... done
-----> Java (using Apache Ant 1.9.3) app detected
-----> Installing OpenJDK 1.8... done
-----> Installing Apache Ant 1.9.3..... [start]
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
-----> Installing Apache Ant 1.9.3..... [done ]!
-----> executing /tmp/build_b7f4e6533731839f113a5addf415fae6/loklak-loklak_server-dbed2e8/.buildpack/apache-ant-1.9.3/bin/ant -Duser.home=/tmp/build_b7f4e6533731839f113a5addf415fae6/loklak-loklak_server-dbed2e8
       Buildfile: /tmp/build_b7f4e6533731839f113a5addf415fae6/loklak-loklak_server-dbed2e8/build.xml

       init:

       build:
           [mkdir] Created dir: /tmp/build_b7f4e6533731839f113a5addf415fae6/loklak-loklak_server-dbed2e8/classes
            [echo] loklak: /tmp/build_b7f4e6533731839f113a5addf415fae6/loklak-loklak_server-dbed2e8/build.xml
           [javac] Compiling 139 source files to /tmp/build_b7f4e6533731839f113a5addf415fae6/loklak-loklak_server-dbed2e8/classes
           [javac] Note: /tmp/build_b7f4e6533731839f113a5addf415fae6/loklak-loklak_server-dbed2e8/src/org/loklak/server/Accounting.java uses unchecked or unsafe operations.
           [javac] Note: Recompile with -Xlint:unchecked for details.

       BUILD SUCCESSFUL
       Total time: 5 seconds
       total 196
       drwx------ 15 u4034 dyno  4096 May 25 09:01 .
       drwx------  3 u4034 dyno  4096 May 25 09:01 ..
       -rw-------  1 u4034 dyno   408 May 25 08:47 app.json
       drwx------  2 u4034 dyno  4096 May 25 08:47 bin
       drwx------  2 u4034 dyno  4096 May 25 08:47 .bluemix
       -rw-------  1 u4034 dyno  2509 May 25 08:47 build.gradle
       drwx------  3 u4034 dyno  4096 May 25 09:01 .buildpack
       -rw-------  1 u4034 dyno  6010 May 25 08:47 build.xml
       drwx------  3 u4034 dyno  4096 May 25 09:01 classes
       -rw-------  1 u4034 dyno  4269 May 25 08:47 .classpath
       -rw-------  1 u4034 dyno   397 May 25 08:47 cloud9-setup.sh
       drwx------  5 u4034 dyno  4096 May 25 08:47 conf
       -rw-------  1 u4034 dyno    83 May 25 08:47 docker-cloud.yml
       -rw-------  1 u4034 dyno    52 May 25 08:47 docker-compose.yml
       -rw-------  1 u4034 dyno   787 May 25 08:47 Dockerfile
       -rw-------  1 u4034 dyno   131 May 25 08:47 .gitignore
       -rwx------  1 u4034 dyno    58 May 25 08:47 gradle_clean.sh
       -rwx------  1 u4034 dyno    80 May 25 08:47 gradle_init.sh
       drwx------  6 u4034 dyno  4096 May 25 09:01 .heroku
       drwx------  9 u4034 dyno  4096 May 25 08:47 html
       -rw-------  1 u4034 dyno   475 May 25 08:47 installation_cloud9.md
       -rw-------  1 u4034 dyno  9299 May 25 08:47 installation_docker.md
       -rw-------  1 u4034 dyno   378 May 25 08:47 installation_generic.md
       -rw-------  1 u4034 dyno   819 May 25 08:47 installation_heroku.md
       drwx------  6 u4034 dyno  4096 May 25 09:01 .jdk
       drwx------  2 u4034 dyno  4096 May 25 08:47 lib
       -rw-------  1 u4034 dyno 26444 May 25 08:47 LICENSE
       -rw-------  1 u4034 dyno   393 May 25 08:47 manifest.yml
       -rw-------  1 u4034 dyno    28 May 25 08:47 Procfile
       drwx------  2 u4034 dyno  4096 May 25 09:01 .profile.d
       -rw-------  1 u4034 dyno   372 May 25 08:47 .project
       -rw-------  1 u4034 dyno  7387 May 25 08:47 README.md
       -rw-------  1 u4034 dyno   426 May 25 08:47 scalingo.json
       drwx------  2 u4034 dyno  4096 May 25 08:47 .settings
       drwx------  3 u4034 dyno  4096 May 25 08:47 src
       -rw-------  1 u4034 dyno    25 May 25 08:47 system.properties
       drwx------  4 u4034 dyno  4096 May 25 08:47 test
       -rw-------  1 u4034 dyno   163 May 25 08:47 .travis.yml
       total 196
       drwx------ 15 u4034 dyno  4096 May 25 09:01 .
       drwx------  3 u4034 dyno  4096 May 25 09:01 ..
       -rw-------  1 u4034 dyno   408 May 25 08:47 app.json
       drwx------  2 u4034 dyno  4096 May 25 08:47 bin
       drwx------  2 u4034 dyno  4096 May 25 08:47 .bluemix
       -rw-------  1 u4034 dyno  2509 May 25 08:47 build.gradle
       drwx------  3 u4034 dyno  4096 May 25 09:01 .buildpack
       -rw-------  1 u4034 dyno  6010 May 25 08:47 build.xml
       drwx------  3 u4034 dyno  4096 May 25 09:01 classes
       -rw-------  1 u4034 dyno  4269 May 25 08:47 .classpath
       -rw-------  1 u4034 dyno   397 May 25 08:47 cloud9-setup.sh
       drwx------  5 u4034 dyno  4096 May 25 08:47 conf
       -rw-------  1 u4034 dyno    83 May 25 08:47 docker-cloud.yml
       -rw-------  1 u4034 dyno    52 May 25 08:47 docker-compose.yml
       -rw-------  1 u4034 dyno   787 May 25 08:47 Dockerfile
       -rw-------  1 u4034 dyno   131 May 25 08:47 .gitignore
       -rwx------  1 u4034 dyno    58 May 25 08:47 gradle_clean.sh
       -rwx------  1 u4034 dyno    80 May 25 08:47 gradle_init.sh
       drwx------  6 u4034 dyno  4096 May 25 09:01 .heroku
       drwx------  9 u4034 dyno  4096 May 25 08:47 html
       -rw-------  1 u4034 dyno   475 May 25 08:47 installation_cloud9.md
       -rw-------  1 u4034 dyno  9299 May 25 08:47 installation_docker.md
       -rw-------  1 u4034 dyno   378 May 25 08:47 installation_generic.md
       -rw-------  1 u4034 dyno   819 May 25 08:47 installation_heroku.md
       drwx------  6 u4034 dyno  4096 May 25 09:01 .jdk
       drwx------  2 u4034 dyno  4096 May 25 08:47 lib
       -rw-------  1 u4034 dyno 26444 May 25 08:47 LICENSE
       -rw-------  1 u4034 dyno   393 May 25 08:47 manifest.yml
       -rw-------  1 u4034 dyno    28 May 25 08:47 Procfile
       drwx------  2 u4034 dyno  4096 May 25 09:01 .profile.d
       -rw-------  1 u4034 dyno   372 May 25 08:47 .project
       -rw-------  1 u4034 dyno  7387 May 25 08:47 README.md
       -rw-------  1 u4034 dyno   426 May 25 08:47 scalingo.json
       drwx------  2 u4034 dyno  4096 May 25 08:47 .settings
       drwx------  3 u4034 dyno  4096 May 25 08:47 src
       -rw-------  1 u4034 dyno    25 May 25 08:47 system.properties
       drwx------  4 u4034 dyno  4096 May 25 08:47 test
       -rw-------  1 u4034 dyno   163 May 25 08:47 .travis.yml
-----> Discovering process types
       Procfile declares types -> web
-----> Compressing...
       Done: 98.4M
-----> Launching...
       Released v5
       https://loklakjavajvm8.herokuapp.com/ deployed to Heroku

Uses jdk1.8

sudheesh001 · 2016-05-25T11:33:31Z

Bluemix deployment working with java 8 http://loklak-server-dispensary-1427.mybluemix.net/api/threaddump.txt

sudheesh001 · 2016-05-25T12:08:17Z

Docker cloud http://loklak-1.loklakjava8.23a887be.cont.dockerapp.io:32770/api/threaddump.txt

Runs jvm.versions.version=1.8.0_91

rmader · 2016-05-25T12:11:03Z

ok, can you mark the checkboxes for all things tested?

rmader · 2016-05-25T12:13:50Z

@Orbiter can you remove the java 7 buildbot?

sudheesh001 · 2016-05-25T12:18:00Z

@treba123 i've marked it after testing for heroku, bluemix and docker cloud. Can someone test it for scalingo ideally it should work since it works for heroku but my trial for scalingo expired @daminisatya @shivenmian @jig08 Could any of you host the java8 branch on scalingo ?

shivenmian · 2016-05-25T12:18:56Z

@sudheesh001 Sure, wait.

shivenmian · 2016-05-25T12:48:24Z

@sudheesh001 It works when I went to https://my.scalingo.com/deploy?source=https://github.com/loklak/loklak_server/tree/java8 (i.e used the deploy button, just that I changed the source from master to java8 branch)

It didn't work when I pulled the java8 branch, and deployed from my local machine.

For the first method: https://loklaksm.scalingo.io/api/threaddump.txt

But why should it not work when you deploy this app from your local machine?

sudheesh001 · 2016-05-25T12:52:05Z

Can i have the scalingo URL deployed please ?

shivenmian · 2016-05-25T12:56:20Z

I'd deployed it, had worked, but it's crashing right now. I'll do it again.

sudheesh001 · 2016-05-25T12:56:45Z

No worries It says 1.8.0_92-cedar14

shivenmian · 2016-05-25T12:57:59Z

Yes it did, just crashed for some reason. I think you can merge the java8 branch to master.

rmader · 2016-05-25T13:08:57Z

Thanks guys! I will wait for the buildbot to be java 8 only, as it will give us build errors for every PR

sudheesh001 · 2016-05-25T13:15:25Z

@treba123 #430 I've removed java7 for automated build on TravisCI

rmader · 2016-05-25T13:45:30Z

@sudheesh001 cool, lets merge that one. Do we still have to wait for anything? The docker thing?

Orbiter · 2016-05-25T18:01:28Z

Great work, do we need to redeploy existing servers?

rmader · 2016-05-26T07:31:24Z

I don't think so, but we'll have to when #427 gets merged. So maybe wait for that

rmader · 2016-05-26T07:31:59Z

Correction: not even then, but as soon as we actually start checking for valid peer hashes

rmader · 2016-05-26T09:30:05Z

Done #441

rmader added the enhancement label May 24, 2016

rmader self-assigned this May 24, 2016

leonmak mentioned this issue May 25, 2016

Changed bluemix url to java8 openjdk #423

Merged

rmader mentioned this issue May 25, 2016

Secure peer key #427

Closed

rmader mentioned this issue May 25, 2016

update to jetty 9.3 #438

Merged

rmader added this to the GSOC 2016 Milestone 10 (Checkpoint) milestone May 25, 2016

rmader added the help wanted label May 25, 2016

rmader closed this as completed May 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to Java 8 #419

Move to Java 8 #419

rmader commented May 24, 2016 •

edited by shivenmian

sudheesh001 commented May 24, 2016

rmader commented May 24, 2016 •

edited

rmader commented May 24, 2016 •

edited

sudheesh001 commented May 24, 2016

Orbiter commented May 24, 2016

Orbiter commented May 24, 2016

sudheesh001 commented May 24, 2016

Orbiter commented May 24, 2016

sudheesh001 commented May 24, 2016

rmader commented May 25, 2016

rmader commented May 25, 2016 •

edited

sudheesh001 commented May 25, 2016

sudheesh001 commented May 25, 2016

sudheesh001 commented May 25, 2016

sudheesh001 commented May 25, 2016

rmader commented May 25, 2016

rmader commented May 25, 2016

sudheesh001 commented May 25, 2016

shivenmian commented May 25, 2016 •

edited

shivenmian commented May 25, 2016 •

edited

sudheesh001 commented May 25, 2016

shivenmian commented May 25, 2016 •

edited

sudheesh001 commented May 25, 2016

shivenmian commented May 25, 2016

rmader commented May 25, 2016

sudheesh001 commented May 25, 2016

rmader commented May 25, 2016

Orbiter commented May 25, 2016

rmader commented May 26, 2016

rmader commented May 26, 2016 •

edited

rmader commented May 26, 2016

Move to Java 8 #419

Move to Java 8 #419

Comments

rmader commented May 24, 2016 • edited by shivenmian

sudheesh001 commented May 24, 2016

rmader commented May 24, 2016 • edited

rmader commented May 24, 2016 • edited

sudheesh001 commented May 24, 2016

Orbiter commented May 24, 2016

Orbiter commented May 24, 2016

sudheesh001 commented May 24, 2016

Orbiter commented May 24, 2016

sudheesh001 commented May 24, 2016

rmader commented May 25, 2016

rmader commented May 25, 2016 • edited

sudheesh001 commented May 25, 2016

sudheesh001 commented May 25, 2016

sudheesh001 commented May 25, 2016

sudheesh001 commented May 25, 2016

rmader commented May 25, 2016

rmader commented May 25, 2016

sudheesh001 commented May 25, 2016

shivenmian commented May 25, 2016 • edited

shivenmian commented May 25, 2016 • edited

sudheesh001 commented May 25, 2016

shivenmian commented May 25, 2016 • edited

sudheesh001 commented May 25, 2016

shivenmian commented May 25, 2016

rmader commented May 25, 2016

sudheesh001 commented May 25, 2016

rmader commented May 25, 2016

Orbiter commented May 25, 2016

rmader commented May 26, 2016

rmader commented May 26, 2016 • edited

rmader commented May 26, 2016

rmader commented May 24, 2016 •

edited by shivenmian

rmader commented May 24, 2016 •

edited

rmader commented May 24, 2016 •

edited

rmader commented May 25, 2016 •

edited

shivenmian commented May 25, 2016 •

edited

shivenmian commented May 25, 2016 •

edited

shivenmian commented May 25, 2016 •

edited

rmader commented May 26, 2016 •

edited